-
Notifications
You must be signed in to change notification settings - Fork 65
Grand Dispatch Queue, Apple Network Connection, Apple SecItem #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #661 +/- ##
==========================================
- Coverage 79.67% 78.58% -1.09%
==========================================
Files 30 30
Lines 6130 6388 +258
==========================================
+ Hits 4884 5020 +136
- Misses 1246 1368 +122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Michael Graeb <[email protected]>
Co-authored-by: Bret Ambrose <[email protected]> Co-authored-by: Vera Xia <[email protected]>
Co-authored-by: Vera Xia <[email protected]> Co-authored-by: Bret Ambrose <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was left over from a few weeks ago. Unsure if its still relevant.
* Cleans up the memory allocated for a `scheduled_iteration_entry`. | ||
*/ | ||
static void s_scheduled_iteration_entry_destroy(struct scheduled_iteration_entry *entry) { | ||
aws_mem_release(entry->allocator, entry); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth asserting that the priority queue node is not in a priority queue, if that is straightforward to check.
Assuming a move back to a linked list, you can definitely assert that the node is not in a list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first step in each iteration is to pop the node from the list to ensure that the currently running entry does not interfere with future scheduling, the node is likely already removed from the list by the time it is destroyed.
Co-authored-by: Vera Xia <[email protected]> Co-authored-by: Bret Ambrose <[email protected]>
Integration of:
Apple's grand dispatch queue with event loop
Apple network framework socket connections
Apple SecItem support
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.