Skip to content

Grand Dispatch Queue, Apple Network Connection, Apple SecItem #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 187 commits into from
Mar 28, 2025

Conversation

sbSteveK
Copy link
Contributor

@sbSteveK sbSteveK commented Jul 29, 2024

Integration of:
Apple's grand dispatch queue with event loop
Apple network framework socket connections
Apple SecItem support

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 56.97674% with 148 lines in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (46974e9) to head (cd3f6ad).

Files with missing lines Patch % Lines
source/channel_bootstrap.c 48.96% 99 Missing ⚠️
source/socket_channel_handler.c 50.00% 17 Missing ⚠️
source/event_loop.c 68.57% 11 Missing ⚠️
source/tls_channel_handler.c 18.18% 9 Missing ⚠️
source/posix/socket.c 86.27% 7 Missing ⚠️
source/linux/epoll_event_loop.c 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
- Coverage   79.67%   78.58%   -1.09%     
==========================================
  Files          30       30              
  Lines        6130     6388     +258     
==========================================
+ Hits         4884     5020     +136     
- Misses       1246     1368     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@bretambrose bretambrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was left over from a few weeks ago. Unsure if its still relevant.

* Cleans up the memory allocated for a `scheduled_iteration_entry`.
*/
static void s_scheduled_iteration_entry_destroy(struct scheduled_iteration_entry *entry) {
aws_mem_release(entry->allocator, entry);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth asserting that the priority queue node is not in a priority queue, if that is straightforward to check.

Assuming a move back to a linked list, you can definitely assert that the node is not in a list.

Copy link
Contributor

@xiazhvera xiazhvera Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first step in each iteration is to pop the node from the list to ensure that the currently running entry does not interfere with future scheduling, the node is likely already removed from the list by the time it is destroyed.

Co-authored-by: Vera Xia <[email protected]>
Co-authored-by: Bret Ambrose <[email protected]>
@xiazhvera xiazhvera merged commit bca5740 into main Mar 28, 2025
51 checks passed
@xiazhvera xiazhvera deleted the grand_dispatch_queue branch March 28, 2025 17:31
@sbSteveK sbSteveK changed the title Grand dispatch queue Grand Dispatch Queue, Apple Network Connection, Apple SecItem Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants