Add back kqueue support on iOS #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
approved these changes
Mar 25, 2025
waahm7
reviewed
Mar 25, 2025
CMakeLists.txt
Outdated
Comment on lines
209
to
211
| if (AWS_USE_APPLE_DISPATCH_QUEUE) | ||
| target_compile_definitions(${PROJECT_NAME} PUBLIC "-DAWS_USE_APPLE_DISPATCH_QUEUE") | ||
| endif() |
There was a problem hiding this comment.
Should be this be under #if Apple?
CMakeLists.txt
Outdated
Comment on lines
185
to
187
| if (AWS_USE_SECITEM) | ||
| target_compile_definitions(${PROJECT_NAME} PUBLIC "-DAWS_USE_SECITEM") | ||
| endif() |
There was a problem hiding this comment.
Should be this be under #if Apple?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
- Coverage 79.65% 79.59% -0.07%
==========================================
Files 30 30
Lines 6120 6120
==========================================
- Hits 4875 4871 -4
- Misses 1245 1249 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Temporary add back kqueue support on iOS . Kqueue support will be eventually replaced by dispatch queue on iOS. #661
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.