Skip to content

chore(deps): fix dependencies #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

chore(deps): fix dependencies #2041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5559265
Update pom.xml to include software.amazon.awssdk:dynamodb
rishav-karanjit Jul 10, 2024
f81a4b4
Dummy commit
rishav-karanjit Jul 10, 2024
61a8541
Dummy commit to run CI
rishav-karanjit Jul 10, 2024
695d30b
Revert making changes to pom.xml
rishav-karanjit Jul 10, 2024
cdea9be
Remove kms and DDB from dependency
rishav-karanjit Jul 10, 2024
e6c041d
Revert change to version
rishav-karanjit Jul 10, 2024
c1f2b76
Bring back kms and update bom version
rishav-karanjit Jul 10, 2024
2a6937e
Bring bavk KMS
rishav-karanjit Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README still has a mistake for the AWS SDK V1's KMS Version.

Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ To use the AWS Encryption SDK for Java you must have:

* **Declare a Dependency on the AWS Encryption SDK in Java and its dependencies**

This library requires the AWS Cryptographic Material Providers Library in Java, and the KMS and DynamoDB clients from the AWS Java SDK V2.
This library requires the AWS Cryptographic Material Providers Library in Java, and the KMS client from the AWS Java SDK V2.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this.
See line 30, which covers this requirement.


The KMS client from the AWS SDK for Java V1 is an **optional** dependency.

Expand All @@ -39,7 +39,7 @@ To use the AWS Encryption SDK for Java you must have:
<dependency>
<groupId>software.amazon.awssdk</groupId>
<artifactId>bom</artifactId>
<version>3.0.1</version>
<version>2.19.1</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand All @@ -54,7 +54,7 @@ To use the AWS Encryption SDK for Java you must have:
<dependency>
<groupId>software.amazon.cryptography</groupId>
<artifactId>aws-cryptographic-material-providers</artifactId>
<version>3.0.1</version>
<version>1.0.2</version>
</dependency>
<dependency>
<groupId>software.amazon.awssdk</groupId>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<dependency>
<groupId>software.amazon.awssdk</groupId>
<artifactId>bom</artifactId>
<version>2.20.91</version>
<version>2.19.1</version>
<optional>true</optional>
<type>pom</type>
<scope>import</scope>
Expand Down
Loading