chore(deps): fix dependencies #2041
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishav-karanjit
changed the title
texastony
requested changes
Jul 10, 2024
| @@ -23,7 +23,7 @@ To use the AWS Encryption SDK for Java you must have: | |||
|
|
|||
| * **Declare a Dependency on the AWS Encryption SDK in Java and its dependencies** | |||
|
|
|||
| This library requires the AWS Cryptographic Material Providers Library in Java from the AWS Java SDK V2. | |||
| This library requires the AWS Cryptographic Material Providers Library in Java, and the KMS client from the AWS Java SDK V2. | |||
There was a problem hiding this comment.
Revert this.
See line 30, which covers this requirement.
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>kms</artifactId> | ||
| <version>2.20.91</version> |
There was a problem hiding this comment.
You do not need to declare a version here.
Read https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/get-started.html
In particular, expand the POM.
Suggested change
| <version>2.20.91</version> |
There was a problem hiding this comment.
The README still has a mistake for the AWS SDK V1's KMS Version.
rishav-karanjit
changed the title
|
The readme needs more fixes then just DDB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Update pom.xml to include software.amazon.awssdk:dynamodb
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: