Implement support for private_append #1931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
force-pushed
the
w43/private-append
branch
from
101c8da to
47b4330
Compare
pguyot
force-pushed
the
w43/private-append
branch
from
47b4330 to
eeb4f7b
Compare
pguyot
force-pushed
the
w43/private-append
branch
2 times, most recently
from
3be1eae to
6b06240
Compare
Add a new `term_reuse_binary` to reuse a refc binary, taking advantage of private_append compiler optimization. Add handling of out of memory errors in term_alloc_refc_binary by raising out of memory error instead of aborting. Update `and_/3` signature in JIT backends to handle and with a new register, and performed few optimizations accordingly by removing unnecessary copy. Signed-off-by: Paul Guyot <[email protected]>
pguyot
force-pushed
the
w43/private-append
branch
from
6b06240 to
322301b
Compare
bettio
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
term_reuse_binaryto reuse a refc binary, taking advantageof private_append compiler optimization.
Add handling of out of memory errors in
term_alloc_refc_binaryby raisingout of memory error instead of aborting.
Replaced uses of
term_create_empty_binarywithterm_create_uninitialized_binarysince we don't need to set the binarycontent to zeroes.
Update
and_/3signature in JIT backends to handle and with a new register,and performed few optimizations accordingly by removing unnecessary copy.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later