Skip to content

Make Instructor/Course optional when leaving a review #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make Instructor/Course optional when leaving a review #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 14 additions & 22 deletions frontend/src/components/courses/Review.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,12 +167,6 @@ export const ReviewForm: React.FC<CourseReviewFormProps> = ({
errors.workPerWeek =
'Please input the average number of hours of work per week.';

// Check relationship selection
if (isFromInstructor && selectedCourseId === undefined)
errors.course = 'Please select a course for this instructor.';
else if (!isFromInstructor && selectedInstructorId === undefined)
errors.instructor = 'Please select an instructor for this course.';

// Check if comments are provided
if (!comments.trim()) errors.comments = 'Please leave a comment.';

Expand Down Expand Up @@ -369,19 +363,21 @@ export const ReviewForm: React.FC<CourseReviewFormProps> = ({
{/* Course selection - when coming from instructor page */}
{isFromInstructor && (
<div>
<label>Course: </label>
<label>Course (Optional): </label>
<div>
<select
className="w-auto p-2 border rounded mb-4"
value={selectedCourseId}
value={selectedCourseId || ''}
onChange={(e) =>
setSelectedCourseId(
parseInt(e.target.value, 10)
e.target.value
? parseInt(e.target.value, 10)
: undefined
)
}
>
<option value="">
Select the course you took with this instructor
Course not listed (general instructor review)
</option>
{courses &&
courses.map((course) => (
Expand All @@ -394,10 +390,7 @@ export const ReviewForm: React.FC<CourseReviewFormProps> = ({
))}
</select>
</div>
{formErrors.course && (
<p className="text-red-500">{formErrors.course}</p>
)}
<p className="pb-2">
<p className="pb-2 text-sm text-gray-600">
If you don&apos;t see a course that should be here,
email [email protected] so we can add it!
</p>
Expand All @@ -407,19 +400,21 @@ export const ReviewForm: React.FC<CourseReviewFormProps> = ({
{/* Instructor selection - when coming from course page */}
{!isFromInstructor && (
<div>
<label>Instructor: </label>
<label>Instructor (Optional): </label>
<div>
<select
className="w-auto p-2 border rounded mb-4"
value={selectedInstructorId}
value={selectedInstructorId || ''}
onChange={(e) =>
setSelectedInstructorId(
parseInt(e.target.value, 10)
e.target.value
? parseInt(e.target.value, 10)
: undefined
)
}
>
<option value="">
Select the instructor for this course
Instructor not listed (general course review)
</option>
{courseInstructors &&
courseInstructors.map((instructor) => (
Expand All @@ -432,10 +427,7 @@ export const ReviewForm: React.FC<CourseReviewFormProps> = ({
))}
</select>
</div>
{formErrors.instructor && (
<p className="text-red-500">{formErrors.instructor}</p>
)}
<p className="pb-2">
<p className="pb-2 text-sm text-gray-600">
If you don&apos;t see a professor that should be here,
email [email protected] so we can add them!
</p>
Expand Down