Refactor Update class for safer backpress and CI/CD stability #1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
requested changes
Oct 12, 2025
| */ | ||
| public class Update { | ||
| public static void main(String[] args) { | ||
| Update updater = new Update(); // reuse instance |
Contributor
There was a problem hiding this comment.
I'm not sure this works. The value of the retired field might be different in a reused object. I'm not fully sure.
Contributor
There was a problem hiding this comment.
If one instance can be reused, then this should all just be static methods, no instances at all. @hboutemy
elharo
requested changes
Oct 12, 2025
| */ | ||
| public class Update { | ||
| public static void main(String[] args) { | ||
| Update updater = new Update(); // reuse instance |
Contributor
There was a problem hiding this comment.
If one instance can be reused, then this should all just be static methods, no instances at all. @hboutemy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Update class to improve CI/CD stability and maintain the same update logic:
The update and lookup logic remain unchanged. These changes ensure smoother execution and better logging for multiple directory updates.