Skip to content

Refactor Update class for safer backpress and CI/CD stability #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Refactor Update class for safer backpress and CI/CD stability #1413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d94b84
Update Update.java
Manas-Dikshit Oct 6, 2025
a2e722e
Merge branch 'master' into master
Manas-Dikshit Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/org/apache/maven/site/update/Update.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,17 @@
* https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-dist-tool/job/master/site/dist-tool-check-errors.html
*/
public class Update {
public static void main(String[] args) {
Update updater = new Update(); // reuse instance
Copy link
Contributor

@elharo elharo Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this works. The value of the retired field might be different in a reused object. I'm not fully sure.

Copy link
Contributor

@elharo elharo Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If one instance can be reused, then this should all just be static methods, no instances at all. @hboutemy

for (String dir : args) {
Path indexPath = Paths.get("content/apt/" + dir + "/index.apt");
try {
updater.doUpdate(indexPath);
System.out.print("\r\33[2K"); // clear line
} catch (IOException e) {
System.err.println("Failed to update: " + indexPath);
e.printStackTrace();

private boolean retired = false;

public static void main(String[] args) throws IOException {
Expand All @@ -44,6 +55,7 @@ public static void main(String[] args) throws IOException {
System.out.println("\r\33[2K");
}
}
}

private void doUpdate(Path index) throws IOException {
System.out.println("updating " + index);
Expand Down