Skip to content

add loadedAccountsDataSize to simulate transaction response #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

add loadedAccountsDataSize to simulate transaction response #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a72f18f
add loadedAccountsDataSize to simulate transaction response
tao-stones Jun 3, 2025
323d0e9
alpha-order new field with type number
tao-stones Jun 5, 2025
42655c0
update test
tao-stones Jun 5, 2025
955d92f
add changeset
tao-stones Jun 5, 2025
4f0ec00
alpha-order error code
tao-stones Jun 5, 2025
72da5e2
update set-transaction-test for added field
tao-stones Jun 5, 2025
451e061
Ran `pnpm style:fix`
steveluscher Jun 6, 2025
a3d0c4e
Change allowed numeric path to `value.loadedAccountsDataSize`
steveluscher Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-baths-rule.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it changes response, thought a changeset is needed?

'@solana/kit': patch
---

Add loadedAccountsDataSize to simulateTransaction response
1 change: 1 addition & 0 deletions packages/errors/src/json-rpc-error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export interface RpcSimulateTransactionResult {
)[];
}[]
| null;
loadedAccountsDataSize: number | null;
logs: string[] | null;
returnData: {
data: [string, 'base64'];
Expand Down
3 changes: 3 additions & 0 deletions packages/rpc-api/src/__tests__/send-transaction-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ describe('sendTransaction', () => {
accounts: null,
cause: new SolanaError(SOLANA_ERROR__TRANSACTION_ERROR__ACCOUNT_NOT_FOUND),
innerInstructions: null,
loadedAccountsDataSize: 0,
logs: [],
returnData: null,
unitsConsumed: 0,
Expand Down Expand Up @@ -283,6 +284,7 @@ describe('sendTransaction', () => {
accounts: null,
cause: new SolanaError(SOLANA_ERROR__TRANSACTION_ERROR__INSUFFICIENT_FUNDS_FOR_FEE),
innerInstructions: null,
loadedAccountsDataSize: 0,
logs: [],
returnData: null,
unitsConsumed: 0,
Expand Down Expand Up @@ -315,6 +317,7 @@ describe('sendTransaction', () => {
accounts: null,
cause: new SolanaError(SOLANA_ERROR__TRANSACTION_ERROR__BLOCKHASH_NOT_FOUND),
innerInstructions: null,
loadedAccountsDataSize: 0,
logs: [],
returnData: null,
unitsConsumed: 0,
Expand Down
13 changes: 12 additions & 1 deletion packages/rpc-api/src/__tests__/simulate-transaction-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ describe('simulateTransaction', () => {
accounts: null,
err: null,
innerInstructions: null,
loadedAccountsDataSize: expect.any(Number),
logs: expect.any(Array),
replacementBlockhash: null,
returnData: null,
Expand Down Expand Up @@ -284,6 +285,7 @@ describe('simulateTransaction', () => {
accounts: null,
err: null,
innerInstructions: null,
loadedAccountsDataSize: expect.any(Number),
logs: expect.any(Array),
replacementBlockhash: null,
returnData: null,
Expand Down Expand Up @@ -324,6 +326,7 @@ describe('simulateTransaction', () => {
accounts: null,
err: 'BlockhashNotFound',
innerInstructions: null,
loadedAccountsDataSize: expect.any(Number),
logs: expect.any(Array),
replacementBlockhash: null,
returnData: null,
Expand Down Expand Up @@ -364,6 +367,7 @@ describe('simulateTransaction', () => {
accounts: null,
err: null,
innerInstructions: null,
loadedAccountsDataSize: expect.any(Number),
logs: expect.any(Array),
replacementBlockhash: {
blockhash: expect.any(String),
Expand Down Expand Up @@ -470,6 +474,7 @@ describe('simulateTransaction', () => {
accounts: null,
err: 'AccountNotFound',
innerInstructions: null,
loadedAccountsDataSize: expect.any(Number),
logs: expect.any(Array),
replacementBlockhash: null,
returnData: null,
Expand Down Expand Up @@ -520,6 +525,7 @@ describe('simulateTransaction', () => {
],
err: null,
innerInstructions: null,
loadedAccountsDataSize: expect.any(Number),
logs: expect.any(Array),
replacementBlockhash: null,
returnData: null,
Expand Down Expand Up @@ -570,6 +576,7 @@ describe('simulateTransaction', () => {
],
err: null,
innerInstructions: null,
loadedAccountsDataSize: expect.any(Number),
logs: expect.any(Array),
replacementBlockhash: null,
returnData: null,
Expand Down Expand Up @@ -637,6 +644,7 @@ describe('simulateTransaction', () => {
],
err: null,
innerInstructions: null,
loadedAccountsDataSize: expect.any(Number),
logs: expect.any(Array),
replacementBlockhash: null,
returnData: null,
Expand Down Expand Up @@ -688,6 +696,7 @@ describe('simulateTransaction', () => {
],
err: null,
innerInstructions: null,
loadedAccountsDataSize: expect.any(Number),
logs: expect.any(Array),
replacementBlockhash: null,
returnData: null,
Expand Down Expand Up @@ -737,7 +746,7 @@ describe('simulateTransaction', () => {
],
err: null,
innerInstructions: null,

loadedAccountsDataSize: expect.any(Number),
logs: expect.any(Array),
replacementBlockhash: null,
returnData: null,
Expand Down Expand Up @@ -793,6 +802,7 @@ describe('simulateTransaction', () => {
],
err: null,
innerInstructions: null,
loadedAccountsDataSize: expect.any(Number),
logs: expect.any(Array),
replacementBlockhash: null,
returnData: null,
Expand Down Expand Up @@ -834,6 +844,7 @@ describe('simulateTransaction', () => {
accounts: null,
err: null,
innerInstructions: null,
loadedAccountsDataSize: expect.any(Number),
logs: expect.any(Array),
replacementBlockhash: null,
returnData: null,
Expand Down
1 change: 1 addition & 0 deletions packages/rpc-api/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ function getAllowedNumericKeypaths(): AllowedNumericKeypaths<RpcApi<SolanaRpcApi
['delinquent', KEYPATH_WILDCARD, 'commission'],
],
simulateTransaction: [
['value', 'loadedAccountsDataSize'],
...jsonParsedAccountsConfigs.map(c => ['value', 'accounts', KEYPATH_WILDCARD, ...c]),
...innerInstructionsConfigs.map(c => ['value', 'innerInstructions', KEYPATH_WILDCARD, ...c]),
],
Expand Down
2 changes: 2 additions & 0 deletions packages/rpc-api/src/simulateTransaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ type WithInnerInstructionsConfig = Readonly<{
type SimulateTransactionApiResponseBase = Readonly<{
/** If the transaction failed, this property will contain the error */
err: TransactionError | null;
/** The number of bytes of all accounts loaded by this transaction */
loadedAccountsDataSize?: number;
/**
* Array of log messages the transaction instructions output during execution, `null` if
* simulation failed before the transaction was able to execute (for example due to an invalid
Expand Down
Loading