add loadedAccountsDataSize to simulate transaction response #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a3d0c4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BundleMonFiles updated (4)
Unchanged files (123)
Total files change +51B +0.01% Final result: ✅ View report in BundleMon website ➡️ |
steveluscher
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
Awesome! Just alpha-order those properties, and then add an allowlist entry to tell the system that it's allowed to be a number instead of a bigint.
You'll almost certainly need to update simulate-transaction.test.ts also.
You can get tests running by doing:
pnpm install
cd packages/rpc-api/
pnpm turbo compile:typedefs compile:js
pnpm dev
The last step starts up a persistent server that runs lint & tests whenever you save a file.
tao-stones
commented
Jun 5, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
There was a problem hiding this comment.
Since it changes response, thought a changeset is needed?
tao-stones
commented
Jun 5, 2025
|
Looks good! I fixed up lint and pushed a change to the keypath. Ironic thing is that your tests won't pass until the validator starts to emit this value, so we'll have to wait to land this PR until then. |
steveluscher
added
the
do-not-close
Thank you!
Ah, that explains why my local test keeping error out! I'll change this PR to "ready for review" (a post fact :D) for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
anza-xyz/agave#6023 adds loaded-accounts-data-size to simulate transaction result.
Summary of Changes
Implements #541.