Skip to content

fix: adopt uv.lock and dependency-groups #4757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2025
Merged

fix: adopt uv.lock and dependency-groups #4757

merged 1 commit into from
Sep 9, 2025

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Sep 5, 2025 •
edited
Loading

  • adds few extra indirect-dependency constraints which were found by
    uv lower resolver, will solve corner cases issues with pip as
    a side effect and speedup installation speed with both
  • replaces development extras with dependency-groups
  • migrates tox.ini into pyproject.toml
  • dependency pinning is now done via uv.lock file

Fixes: AAP-52655

@ssbarnea ssbarnea requested a review from a team as a code owner September 5, 2025 14:24
@ssbarnea ssbarnea enabled auto-merge (squash) September 5, 2025 14:24
@github-actions github-actions bot added the fix label Sep 5, 2025
@ssbarnea ssbarnea disabled auto-merge September 8, 2025 12:12
@ssbarnea ssbarnea marked this pull request as draft September 8, 2025 12:12
@ssbarnea ssbarnea marked this pull request as ready for review September 9, 2025 11:48
@ssbarnea
fix: adopt uv.lock and dependency-groups
335ac62 
- adds few extra indirect-dependency constraints which were found by
  uv lower resolver, will solve corner cases issues with pip as
  a side effect and speedup installation speed with both
- replaces development extras with dependency-groups
- migrates tox.ini into pyproject.toml

Fixes: AAP-52655
@ssbarnea ssbarnea merged commit 1a47792 into main Sep 9, 2025
24 of 25 checks passed
@ssbarnea ssbarnea deleted the fix/pyproject branch September 9, 2025 12:33
@sdodsley
Copy link

sdodsley commented Sep 9, 2025

@ssbarnea what happened here. This PR has broken our CI system as the ansible-lint job is failing

Run reqs_file=$(git rev-parse --show-toplevel)/.git/ansible-lint-requirements.txt
--2025-09-09 13:03:08--  https://raw.githubusercontent.com/ansible/ansible-lint/main/.config/requirements-lock.txt
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 185.199.108.133, 185.199.109.133, 185.199.110.133, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|185.199.108.133|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2025-09-09 13:03:08 ERROR 404: Not Found.

@vedmonds vedmonds mentioned this pull request Sep 9, 2025
Closed
Qalthos added a commit to Qalthos/ansible-lint that referenced this pull request Sep 9, 2025
@Qalthos
Revert "fix: adopt uv.lock and dependency-groups (ansible#4757)"
d9ca2c4 
This reverts commit 1a47792.
Qalthos added a commit to Qalthos/ansible-lint that referenced this pull request Sep 9, 2025
@Qalthos
Reapply "fix: adopt uv.lock and dependency-groups (ansible#4757)"
1563be4 
This reverts commit d9ca2c4.
Qalthos added a commit that referenced this pull request Sep 9, 2025
@Qalthos
Revert "fix: adopt uv.lock and dependency-groups (#4757)" (#4760)
7ef0ba8
Qalthos added a commit to Qalthos/ansible-lint that referenced this pull request Sep 9, 2025
@Qalthos
Reapply "fix: adopt uv.lock and dependency-groups (ansible#4757)"
7a2cea2 
This reverts commit d9ca2c4.
Qalthos added a commit that referenced this pull request Sep 9, 2025
@Qalthos
Reapply "fix: adopt uv.lock and dependency-groups (#4757)" (#4761)
3a69a21
@carlos-lehmann carlos-lehmann mentioned this pull request Oct 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssbarnea @sdodsley