-
Notifications
You must be signed in to change notification settings - Fork 19
Fix/update imperative controller #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tisla1080
wants to merge
5
commits into
develop
Choose a base branch
from
fix/update-imperative-controller
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a89d815
fix: use MonoResponseEntityCreator for update response instead of Cre…
tisla1080 6e2c6b2
feat: NullServiceResponse class for cases where returning null is req…
tisla1080 bfc2d28
fix: health check gdha variable name
tisla1080 0f7e1e1
fix: add missing RequestBody and Valid annotations
tisla1080 d36dc6c
feat: undo request body and valid annotations
tisla1080 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
...rc/main/java/io/americanexpress/synapse/service/imperative/model/NullServiceResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* | ||
| * Copyright 2020 American Express Travel Related Services Company, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License | ||
| * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
| * or implied. See the License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package io.americanexpress.synapse.service.imperative.model; | ||
|
|
||
| /** | ||
| * {@code NullServiceResponse} is used whenever a null response is required from a service. The service can just return | ||
| * NullServiceResponse.INSTANCE rather than just returning null directly as this class also extends {@code BaseServiceResponse} | ||
| * adhering to the prototype contracts. | ||
| */ | ||
| public class NullServiceResponse implements BaseServiceResponse { | ||
|
|
||
| /** | ||
| * Returns a null instance as a singleton pattern for when a null response is required from the service. | ||
| */ | ||
| public static final NullServiceResponse INSTANCE = null; | ||
|
|
||
| /** | ||
| * Private constructor to prevent multiple instances being made. | ||
| */ | ||
| private NullServiceResponse() { | ||
|
|
||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rename this file to either EmptyServiceResponse or NoServiceResponse or better a name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we thought about it but if this class's INSTANCE method is returning back Null would it make sense to have EmptyServiceResponse.INSTANCE = null instead of NullServiceResponse.INSTANCE = null? if you think so then I'm good to change it