Fix/update imperative controller #323
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whoswendy
approved these changes
Dec 12, 2024
guttff
reviewed
Jan 30, 2025
| * NullServiceResponse.INSTANCE rather than just returning null directly as this class also extends {@code BaseServiceResponse} | ||
| * adhering to the prototype contracts. | ||
| */ | ||
| public class NullServiceResponse implements BaseServiceResponse { |
There was a problem hiding this comment.
I would rename this file to either EmptyServiceResponse or NoServiceResponse or better a name.
There was a problem hiding this comment.
we thought about it but if this class's INSTANCE method is returning back Null would it make sense to have EmptyServiceResponse.INSTANCE = null instead of NullServiceResponse.INSTANCE = null? if you think so then I'm good to change it
guttff
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MonoResponseEntityCreatorinstead ofCreateResponseEntityCreatorsince we usually return null or a response class when updatingNullServiceResponseclass to be used for all cases where a null response is preferred as a possible return value.Rather than return
nulldirectly, users can utilize this class and returnNullServiceResponse.INSTANCE(which returns null) instead as it also implementsBaseServiceResponseadhering to the generic parameter contract set in all our controllers.DISCUSSION: Is there another name that would fit better than just
NullServiceResponse? (keeping in mind our use case would be that we want to returnnullas a value?