Skip to content

Rename arbiter module to verilog_axis_arbiter #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olofk
Copy link

@olofk olofk commented Oct 13, 2022

arbiter is a reasonably common module name. Avoid namespace collisions by prefixing it with verilog_axis_

@alexforencich
Copy link
Owner

It's a sensible idea, but I don't like the prefix verilog_axis_. Yes, I suppose it is the name of the repo, but pretty much everything else in the repo has the prefix axis_. And axis_arbiter is problematic because the arbiter doesn't really have anything in particular to do with AXI stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants