Skip to content

fix(spokepool): Support v3.5 fills #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(spokepool): Support v3.5 fills #2236

wants to merge 1 commit into from

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented May 7, 2025

No description provided.

@pxrl
Copy link
Contributor Author

pxrl commented May 7, 2025

nb. I had to apply these updates to make slow fill requests for a user who mis-specified their fees on a deposit with infinite expiry.

// If the outputToken is 0x0, naiively infer the correct outputToken. Auto-submission is prevented in this case.
const autoOutputToken = depositArgs.outputToken === ZERO_BYTES;
const outputToken = autoOutputToken
? sdkUtils.toAddressType(TOKEN_SYMBOLS_MAP[symbol].addresses[destinationChainId], destinationChainId).toBytes32()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use sdk utils resolveSymbolOnChain or resolveSymbolOnChain here?

Copy link
Member

@nicholaspai nicholaspai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion

Copy link
Member

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending the linter

@pxrl pxrl mentioned this pull request May 12, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants