-
Notifications
You must be signed in to change notification settings - Fork 72
feat: support rebalancing via OFT #2133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
Co-authored-by: Paul <[email protected]>
…her than multiple. Cleanup test script Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
31994ec
to
0e055ea
Compare
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
Just to circle back to this:
Discussed separately - the experience with the existing tests is that they require a lot of boilerplate, such that the ratio of test:implementation starts to become overweight test. It also debatable how useful some of the tests are, since they're typically being implemented against mocked implementations that may not match reality. The adapter implementation itself is not super complicated; we should instead aim for a future improvement to narrow the scope of our tests for high leverage and low-maintenance testing. |
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
@pxrl @bmzig I've updated this PR and corrected the logic for tracking L1 -> L2 events. Previous if conditions made Hub -> Spoke event tracking incorrect. Please take a look. This is the change b3d65ac ✅ L1 -> L2 rebalance test: layerzero scan link |
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
This PR introduces
OFTBridge
object, which supports sending any token from Ethereum to OFT-supported chain.I've tested:
yarn relay
with custom inventory config. txP.S. This PR depends on another PR in contracts repo for some IOFT interfaces from typechain.
Closes ACX-3763, ACX-3764, ACX-3765