Skip to content

Matter Window Covering: Remove default tilt preset #2565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

Matter Window Covering: Remove default tilt preset #2565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 9 additions & 20 deletions drivers/SmartThings/matter-window-covering/src/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ local battery_support = {
}
local REVERSE_POLARITY = "__reverse_polarity"
local PRESET_LEVEL_KEY = "__preset_level_key"
local PRESET_LEVEL = 50
local DEFAULT_PRESET_LEVEL = 50

local function find_default_endpoint(device, cluster)
local res = device.MATTER_DEFAULT_ENDPOINT
Expand Down Expand Up @@ -78,7 +78,7 @@ local function device_init(driver, device)
device:emit_event(capabilities.windowShadePreset.supportedCommands({"presetPosition", "setPresetPosition"}, {visibility = {displayed = false}}))
local preset_position = device:get_field(PRESET_LEVEL_KEY) or
(device.preferences ~= nil and device.preferences.presetPosition) or
PRESET_LEVEL
DEFAULT_PRESET_LEVEL
device:emit_event(capabilities.windowShadePreset.position(preset_position, {visibility = {displayed = false}}))
device:set_field(PRESET_LEVEL_KEY, preset_position, {persist = true})
end
Expand Down Expand Up @@ -131,25 +131,14 @@ local function device_removed(driver, device) log.info("device removed") end

-- capability handlers
local function handle_preset(driver, device, cmd)
local lift_value = device:get_latest_state(
"main", capabilities.windowShadePreset.ID, capabilities.windowShadePreset.position.NAME
) or DEFAULT_PRESET_LEVEL
local hundredths_lift_percent = (100 - lift_value) * 100
local endpoint_id = device:component_to_endpoint(cmd.component)
local lift_eps = device:get_endpoints(clusters.WindowCovering.ID, {feature_bitmap = clusters.WindowCovering.types.Feature.LIFT})
local tilt_eps = device:get_endpoints(clusters.WindowCovering.ID, {feature_bitmap = clusters.WindowCovering.types.Feature.TILT})
if #lift_eps > 0 then
Copy link
Contributor Author

@nickolas-deboom nickolas-deboom Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this check isn't needed since any device using a profile with the windowShadePresetcapability supports the LIFT feature.

local lift_value = device:get_latest_state(
"main", capabilities.windowShadePreset.ID, capabilities.windowShadePreset.position.NAME
) or PRESET_LEVEL
local hundredths_lift_percent = (100 - lift_value) * 100
local req = clusters.WindowCovering.server.commands.GoToLiftPercentage(
device, endpoint_id, hundredths_lift_percent
)
device:send(req)
end
if #tilt_eps > 0 then
local req = clusters.WindowCovering.server.commands.GoToTiltPercentage(
device, endpoint_id, PRESET_LEVEL * 100
)
device:send(req)
end
device:send(clusters.WindowCovering.server.commands.GoToLiftPercentage(
device, endpoint_id, hundredths_lift_percent
))
end

local function handle_set_preset(driver, device, cmd)
Expand Down
3 changes: 0 additions & 3 deletions drivers/SmartThings/matter-window-covering/src/test/test_matter_window_covering.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,9 +789,6 @@ test.register_coroutine_test(
test.socket.matter:__expect_send(
{mock_device.id, WindowCovering.server.commands.GoToLiftPercentage(mock_device, 10, (100 - PRESET_LEVEL) * 100)}
)
test.socket.matter:__expect_send(
{mock_device.id, WindowCovering.server.commands.GoToTiltPercentage(mock_device, 10, 5000)}
)
end
)

Expand Down
Loading