Matter Window Covering: Remove default tilt preset #2565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickolas-deboom
commented
Nov 18, 2025
| local endpoint_id = device:component_to_endpoint(cmd.component) | ||
| local lift_eps = device:get_endpoints(clusters.WindowCovering.ID, {feature_bitmap = clusters.WindowCovering.types.Feature.LIFT}) | ||
| local tilt_eps = device:get_endpoints(clusters.WindowCovering.ID, {feature_bitmap = clusters.WindowCovering.types.Feature.TILT}) | ||
| if #lift_eps > 0 then |
Contributor
Author
There was a problem hiding this comment.
Note that this check isn't needed since any device using a profile with the windowShadePresetcapability supports the LIFT feature.
|
Channel deleted. |
Test Results 71 files 469 suites 0s ⏱️ Results for commit 631dc6c. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3158029 |
hcarter-775
reviewed
Nov 18, 2025
hcarter-775
approved these changes
Nov 18, 2025
greens
approved these changes
Nov 19, 2025
Remove the default tilt preset level of 50%, which is not ideal for user experience.
nickolas-deboom
force-pushed
the
matter-window-covering-remove-default-tilt-preset
branch
from
631dc6c to
3158029
Compare
nickolas-deboom
deleted the
matter-window-covering-remove-default-tilt-preset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
GoToTiltPercentagecommand sent when thepresetPositioncapability command is received, which previously would set the tilt preset level to a default level of 50%. A new capability will be introduced later to support setting the tilt preset level.