Skip to content

Conversation

nikmace
Copy link
Contributor

@nikmace nikmace commented Sep 18, 2025

Fix for #3638.

  • Returns true when validating a package for an OnPremise system. Extra validation now happens only for packages when system is CloudReady.

Copy link

changeset-bot bot commented Sep 18, 2025

🦋 Changeset detected

Latest commit: 76d2f3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/create Patch
@sap-ux/deploy-config-sub-generator Patch
@sap-ux/ui-service-inquirer Patch
@sap-ux/ui-service-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikmace nikmace requested a review from a team September 18, 2025 13:04
Copy link
Contributor

@mmilko01 mmilko01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset OK
Changes look good
Excellent test coverage
Did not test manually

Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset is good.
CHanges are good.
Appropiate test coverage.

Copy link

@nikmace nikmace merged commit bfdbaca into main Sep 23, 2025
16 checks passed
@nikmace nikmace deleted the fix/3638/package-validation branch September 23, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants