fix: Deploy Config generator should not validate the package for OnPremise systems for ADP (#3639)

* fix: do not validate the package for OnPremise systems

* chore: update cset

Author: nikmace

.changeset/loud-ghosts-prove.md

@@ -0,0 +1,5 @@
+---
+'@sap-ux/abap-deploy-config-inquirer': patch
+---
+
+fix: Deploy Config generator should not validate the package for OnPremise systems for ADP

packages/abap-deploy-config-inquirer/src/prompts/validators.ts

@@ -647,14 +647,10 @@ export function validateConfirmQuestion(overwrite: boolean): boolean {
  */
 async function validatePackageType(input: string, backendTarget?: BackendTarget): Promise<boolean | string> {
     const isS4HC = PromptState?.abapDeployConfig?.isS4HC;
-    if (isS4HC === false && input === DEFAULT_PACKAGE_ABAP) {
+    if (!isS4HC) {
+        LoggerHelper.logger.debug(`System is OnPremise, skipping package "${input}" type validation`);
         return true;
     }
-    const packageType = isS4HC ? AdaptationProjectType.CLOUD_READY : AdaptationProjectType.ON_PREMISE;
-    const errorMsg =
-        packageType === AdaptationProjectType.CLOUD_READY
-            ? t('errors.validators.invalidCloudPackage')
-            : t('errors.validators.invalidOnPremPackage');
     const systemInfoResult = await getSystemInfo(input, backendTarget);
     if (!systemInfoResult.apiExist) {
         return true;
@@ -665,9 +661,9 @@ async function validatePackageType(input: string, backendTarget?: BackendTarget)
         return true;
     }
 
-    const isValidPackageType = types?.length === 1 && types[0] === packageType;
+    const isValidPackageType = types?.length === 1 && types[0] === AdaptationProjectType.CLOUD_READY;
 
-    return isValidPackageType ? true : errorMsg;
+    return isValidPackageType ? true : t('errors.validators.invalidCloudPackage');
 }
 
 /**

packages/abap-deploy-config-inquirer/test/prompts/validators.test.ts

@@ -448,10 +448,10 @@ describe('Test validators', () => {
             expect(result).toBe(true);
         });
 
-        it('should return true for onPremise system with default onPremise package', async () => {
+        it('should return true for onPremise system', async () => {
             PromptState.abapDeployConfig.isS4HC = false;
             const getSystemInfoSpy = jest.spyOn(serviceProviderUtils, 'getSystemInfo');
-            const result = await validatePackage('$TMP', previousAnswers, {
+            const result = await validatePackage('ZPACKAGE', previousAnswers, {
                 additionalValidation: { shouldValidatePackageType: true }
             });
             expect(getSystemInfoSpy).not.toHaveBeenCalled();