Skip to content

Try to fix the spurious error in FileSocketTransportTest. #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sapmachine
Choose a base branch
from
+3 −2
Open

Try to fix the spurious error in FileSocketTransportTest. #2029

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ef1ac3
Try to fix the spurious error in FileSocketTransportTest.
schmelter-sap Jul 31, 2025
bb65846
Update copyright year
schmelter-sap Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/jdk/com/sun/jdi/FileSocketTransportTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2018, 2024 SAP SE. All rights reserved.
* Copyright (c) 2018, 2025 SAP SE. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -62,6 +62,8 @@ private static int handshake(String path, byte[] handshake, byte[] reply) throws
}
ByteBuffer in = ByteBuffer.wrap(reply);
int result = channel.read(in);
// When we are connected and have received at least one byte, the file should be deleted.
checkSocketDeleted(path);
channel.close();

return result;
Expand Down Expand Up @@ -138,7 +140,6 @@ public static void main(String[] args) throws Throwable {
Thread.sleep(3000);
checkSocketPresent(socketName);
read = handshake(socketName, handshake, received);
checkSocketDeleted(socketName);
assertEquals(new String(handshake, "UTF-8"),
new String(received, "UTF-8"));
assertEquals(read, received.length);
Expand Down
Loading