Skip to content

Try to fix the spurious error in FileSocketTransportTest. #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sapmachine
Choose a base branch
from

Conversation

schmelter-sap
Copy link
Member

This moves the test for the deletion of the socket file after connection to an earlier time.

fixes #2028

@schmelter-sap schmelter-sap requested a review from ArnoZeller July 31, 2025 08:51
@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

Copy link
Member

@ArnoZeller ArnoZeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

Copy link
Member

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the copyright year.

Did you also check the CI failures?

@schmelter-sap
Copy link
Member Author

Please update the copyright year.

Done

Did you also check the CI failures?

They were not related to the test (GetStackTraceALotWhenBlocking failed und ppc64le cross build could not download packages).

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

2 similar comments
@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spurious failures in FileSocketTransportTest
5 participants