Skip to content

disable more of profiler test #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

disable more of profiler test #1617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c26f2c9
Update tracer_gtest.cpp
JeniferC99 Oct 30, 2025
4da8e77
Update profiler_gtest.cpp
JeniferC99 Oct 30, 2025
704c568
Merge branch 'develop' into JeniferC99-patch-1
venkat1361 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/rocprofiler/tests-v2/featuretests/profiler/profiler_gtest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ class HelloWorldTest : public ProfilerTest {

// Test:1 Compares total num of kernel-names in golden output against current
// profiler output
TEST_F(HelloWorldTest, WhenRunningProfilerWithAppThenKernelNumbersMatchWithGoldenOutput) {
TEST_F(HelloWorldTest, DISABLED_WhenRunningProfilerWithAppThenKernelNumbersMatchWithGoldenOutput) {
// kernel info in current profiler run
std::vector<profiler_kernel_info_t> current_kernel_info;

Expand Down
6 changes: 3 additions & 3 deletions projects/rocprofiler/tests-v2/featuretests/tracer/tracer_gtest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ TEST_F(HelloWorldTest, DISABLED_WhenRunningTracerWithAppThenKernelInfoMatchWithG

// Test:2 Compares order of kernel-names in golden output against current
// tracer output
TEST_F(HelloWorldTest, WhenRunningTracerWithAppThenFunctionNamesMatchWithGoldenOutput) {
TEST_F(HelloWorldTest, DISABLED_WhenRunningTracerWithAppThenFunctionNamesMatchWithGoldenOutput) {
// kernel info in current tracer run
std::vector<tracer_kernel_info_t> current_kernel_info;
GetKernelInfoForRunningApplication(&current_kernel_info);
Expand All @@ -262,7 +262,7 @@ TEST_F(HelloWorldTest, WhenRunningTracerWithAppThenFunctionNamesMatchWithGoldenO

// Test:3 Compares order of kernel-names in golden output against current
// tracer output
TEST_F(HelloWorldTest, WhenRunningTracerWithAppThenKernelDurationShouldBePositive) {
TEST_F(HelloWorldTest, DISABLED_WhenRunningTracerWithAppThenKernelDurationShouldBePositive) {
// kernel info in current tracer run
std::vector<tracer_kernel_info_t> current_kernel_info;

Expand All @@ -274,7 +274,7 @@ TEST_F(HelloWorldTest, WhenRunningTracerWithAppThenKernelDurationShouldBePositiv

// Test:4 Compares end-time is greater than start-time in current
// tracer output
TEST_F(HelloWorldTest, WhenRunningTracerWithAppThenEndTimeIsGreaterThenStartTime) {
TEST_F(HelloWorldTest, DISABLED_WhenRunningTracerWithAppThenEndTimeIsGreaterThenStartTime) {
Copy link

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'Then' to 'Than' in test name. The test name should be 'EndTimeIsGreaterThanStartTime' not 'EndTimeIsGreaterThenStartTime'.

Suggested change
TEST_F(HelloWorldTest, DISABLED_WhenRunningTracerWithAppThenEndTimeIsGreaterThenStartTime) {
TEST_F(HelloWorldTest, DISABLED_WhenRunningTracerWithAppThenEndTimeIsGreaterThanStartTime) {

Copilot uses AI. Check for mistakes.
// kernel info in current profiler run
std::vector<tracer_kernel_info_t> current_kernel_info;

Expand Down
Loading