disable more of profiler test #1617
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR disables four test cases across two test files by adding the DISABLED_ prefix to their test names. The tests are being temporarily disabled, likely due to flakiness or environment-specific issues that need to be addressed separately.
- Disabled three tracer tests in
tracer_gtest.cpp - Disabled one profiler test in
profiler_gtest.cpp
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/rocprofiler/tests-v2/featuretests/tracer/tracer_gtest.cpp | Disabled three test cases: function name matching, kernel duration validation, and end time comparison |
| projects/rocprofiler/tests-v2/featuretests/profiler/profiler_gtest.cpp | Disabled one test case for kernel number validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Test:4 Compares end-time is greater than start-time in current | ||
| // tracer output | ||
| TEST_F(HelloWorldTest, WhenRunningTracerWithAppThenEndTimeIsGreaterThenStartTime) { | ||
| TEST_F(HelloWorldTest, DISABLED_WhenRunningTracerWithAppThenEndTimeIsGreaterThenStartTime) { |
There was a problem hiding this comment.
Corrected spelling of 'Then' to 'Than' in test name. The test name should be 'EndTimeIsGreaterThanStartTime' not 'EndTimeIsGreaterThenStartTime'.
Suggested change
| TEST_F(HelloWorldTest, DISABLED_WhenRunningTracerWithAppThenEndTimeIsGreaterThenStartTime) { | |
| TEST_F(HelloWorldTest, DISABLED_WhenRunningTracerWithAppThenEndTimeIsGreaterThanStartTime) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://rocm-ci.amd.com//job/rocm-tests/32296/testReport/junit/tests/TestSuite/test_rocprofiler_tests_runFeatureTests_/
failing intemittent test