-
Notifications
You must be signed in to change notification settings - Fork 8
Implement pytest for 03_all_store/all_store_bench.py with kernel-level testing #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/fix-57
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6633882
Initial plan
Copilot 971b264
Add pytest for 03_all_store/all_store_bench.py
Copilot 831c2de
Remove assertions from test to match load_bench test pattern
Copilot 760841f
Apply final formatting to test_all_store_bench.py
Copilot d5979a4
Fix test_all_store_bench.py to avoid barrier crash by testing kernel …
Copilot e244292
Apply Ruff auto-fixes
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
#!/usr/bin/env python3 | ||
# SPDX-License-Identifier: MIT | ||
# Copyright (c) 2025 Advanced Micro Devices, Inc. All rights reserved. | ||
|
||
import pytest | ||
import torch | ||
import triton | ||
import triton.language as tl | ||
import numpy as np | ||
import iris | ||
|
||
import importlib.util | ||
from pathlib import Path | ||
|
||
current_dir = Path(__file__).parent | ||
file_path = (current_dir / "../../examples/03_all_store/all_store_bench.py").resolve() | ||
module_name = "all_store_bench" | ||
spec = importlib.util.spec_from_file_location(module_name, file_path) | ||
module = importlib.util.module_from_spec(spec) | ||
spec.loader.exec_module(module) | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"dtype", | ||
[ | ||
torch.int8, | ||
torch.float16, | ||
torch.bfloat16, | ||
torch.float32, | ||
], | ||
) | ||
@pytest.mark.parametrize( | ||
"buffer_size, heap_size", | ||
[ | ||
((1 << 32), (1 << 33)), | ||
], | ||
) | ||
@pytest.mark.parametrize( | ||
"block_size", | ||
[ | ||
512, | ||
1024, | ||
], | ||
) | ||
def test_all_store_bench(dtype, buffer_size, heap_size, block_size): | ||
shmem = iris.iris(heap_size) | ||
num_ranks = shmem.get_num_ranks() | ||
cur_rank = shmem.get_rank() | ||
|
||
element_size_bytes = torch.tensor([], dtype=dtype).element_size() | ||
n_elements = buffer_size // element_size_bytes | ||
buffer = shmem.zeros(n_elements, device="cuda", dtype=dtype) | ||
|
||
# Simple test similar to load_bench - just test the kernel functionality | ||
# without the complex benchmarking infrastructure | ||
grid = lambda meta: (triton.cdiv(n_elements, meta["BLOCK_SIZE"]),) | ||
|
||
# Test all_store_kernel directly, similar to how load_bench tests the load_kernel | ||
if cur_rank < min(num_ranks, 8): # Only test with a reasonable number of ranks | ||
module.all_store_kernel[grid]( | ||
buffer, | ||
cur_rank, | ||
n_elements, | ||
num_ranks, | ||
block_size, | ||
shmem.get_heap_bases(), | ||
) | ||
|
||
|
||
def _torch_dtype_to_str(dtype): | ||
"""Helper function to convert torch dtype to string format expected by the module""" | ||
dtype_map = { | ||
torch.float16: "fp16", | ||
torch.float32: "fp32", | ||
torch.int8: "int8", | ||
torch.bfloat16: "bf16", | ||
} | ||
return dtype_map[dtype] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.