Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 30, 2025

This PR adds a pytest test file for the all-store benchmark that focuses on testing the core kernel functionality rather than the full benchmarking infrastructure.

Implementation

The test follows the same pattern as test_load_bench.py by:

  • Testing the kernel directly: Calls all_store_kernel instead of the full run_experiment() function
  • Avoiding synchronization issues: Removes barrier calls that were causing Fatal Python errors in CI
  • Parametrized testing: Covers multiple data types (int8, float16, bfloat16, float32), buffer sizes, and block sizes
  • Minimal resource usage: Tests core functionality without expensive benchmarking overhead

Why Kernel-Level Testing

The original approach of calling run_experiment() caused crashes due to GPU synchronization barriers in the CI environment. By testing the all_store_kernel directly, we:

  • Validate the core RMA store functionality
  • Avoid environment-specific synchronization issues
  • Follow the established pattern from test_load_bench.py
  • Maintain fast, reliable test execution

The test ensures the all-store kernel can be invoked with various data types and configurations, providing confidence in the core functionality without requiring the full multi-GPU benchmarking setup.

Fixes #57.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] Implement pytest for 03_all_store/all_store_bench.py Implement pytest for 03_all_store/all_store_bench.py Aug 30, 2025
@Copilot Copilot AI requested a review from mawad-amd August 30, 2025 22:06
Copilot finished work on behalf of mawad-amd August 30, 2025 22:06
Copilot finished work on behalf of mawad-amd August 31, 2025 03:29
@Copilot Copilot AI changed the title Implement pytest for 03_all_store/all_store_bench.py Implement pytest for 03_all_store/all_store_bench.py with kernel-level testing Aug 31, 2025
Copilot finished work on behalf of mawad-amd August 31, 2025 03:37
@Copilot Copilot AI requested a review from mawad-amd August 31, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement pytest for 03_all_store/all_store_bench.py
2 participants