-
Notifications
You must be signed in to change notification settings - Fork 336
distribute electricity demand by JRC energy atlas #1829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
At first glance, i am very surprised how well the naive electricity demand downscaling by gdp/pop did in comparison to this detailed dataset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the electricity demand distribution methodology to use more accurate data sources. Instead of relying solely on NUTS3-based distribution using GDP and population, it now incorporates high-resolution raster data from the JRC Energy Atlas for EU countries and specific consumption statistics for Great Britain.
- Implements new distribution methods using JRC Energy Atlas 1km×1km raster data for EU countries
- Adds Great Britain-specific distribution using local authority electricity consumption data
- Maintains NUTS3-based fallback for non-EU countries
- Adds configuration option for substation-only distribution
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
scripts/build_electricity_demand_base.py | Complete refactor of distribution logic with new functions for different data sources |
rules/retrieve.smk | Adds data retrieval rules for JRC Energy Atlas, GB consumption data, and UK local authorities |
rules/build_electricity.smk | Updates input dependencies for new data sources |
envs/environment.yaml | Adds rasterstats dependency for raster processing |
doc/retrieve.rst | Documents new data retrieval rules |
doc/release_notes.rst | Adds release notes for the feature |
doc/data-retrieval.rst | Documents new data sources with licensing information |
doc/configtables/load.csv | Documents new substation_only configuration option |
config/config.default.yaml | Adds substation_only configuration with default value |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Parameters | ||
---------- | ||
fn : str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameter name in docstring doesn't match function parameter. Should be 'raster_fn' instead of 'fn'.
fn : str | |
raster_fn : str |
Copilot uses AI. Check for mistakes.
- **License:** CC-BY 4.0 (https://jeodpp.jrc.ec.europa.eu/ftp/jrc-opendata/EIGL-Data/RASTER/copyright.txt) | ||
- **Description:** Contains 1km by 1km raster data of annual electricity demand per EU country. | ||
|
||
``data/demand-distribution/Subnational_electricity_consumption_statistics_2005-2023.xlsx` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing closing backtick for the filename. Should end with two backticks: data/demand-distribution/Subnational_electricity_consumption_statistics_2005-2023.xlsx
``data/demand-distribution/Subnational_electricity_consumption_statistics_2005-2023.xlsx` | |
``data/demand-distribution/Subnational_electricity_consumption_statistics_2005-2023.xlsx`` |
Copilot uses AI. Check for mistakes.
Net Zero | ||
<https://www.gov.uk/government/statistics/regional-and-local-authority-electricity-consumption-statistics>`__. | ||
Other non-EU countries still use NUTS3-based distribution keys from GDP and | ||
population. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing whitespace after period should be removed.
population. | |
population. |
Copilot uses AI. Check for mistakes.
Closes #1810 .
Changes proposed in this Pull Request
Distributing country-level electricity demand time series to subnational model
regions of EU countries now uses data from the JRC Energy Atlas.
This dataset provides electricity consumption on a 1 km by 1 km raster for the year, which is more accurate than the previous NUTS3-based distribution.
Another dataset is used for Great Britain from the Department for Energy Security and Net Zero.
Other non-EU countries still use NUTS3-based distribution keys from GDP and population.
New Dataset Visualization
Area-normalized demand (master versus feature)
Checklist
envs/environment.yaml
.config/config.default.yaml
.doc/configtables/*.csv
.doc/data_sources.rst
.doc/release_notes.rst
is added.