Skip to content

Conversation

amos-schledorn
Copy link
Contributor

replaces #1714

@amos-schledorn amos-schledorn requested a review from Copilot July 9, 2025 15:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reallocates heat pump capital expenditure to the heat bus by updating link definitions and revising efficiency and cost calculations for heat pumps.

  • Switches low-voltage attachment for heat pumps from electricity to heat bus
  • Reorders bus assignments in add_heat to reflect heat-centric capex allocation
  • Updates efficiency formulas and cost parameters, adding dispatch limits (p_max_pu, p_min_pu)

@amos-schledorn amos-schledorn marked this pull request as draft July 9, 2025 16:07
@amos-schledorn amos-schledorn force-pushed the feat-allocate-heat-pump-capex-on-heat-bus branch from 4bc3180 to 39d3a0c Compare July 22, 2025 15:17
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I assume you double-checked that energy balances are plausible on heat versus electricity side? Then, good to go.

/ costs.at[costs_name, "efficiency"],
* ratio,
p_max_pu=0,
p_min_pu=-1 * efficiency / efficiency.clip(lower=0.001),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
p_min_pu=-1 * efficiency / efficiency.clip(lower=0.001),
p_min_pu=-1 * efficiency / efficiency.clip(lower=0.001).replace(1000, 0),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants