-
Notifications
You must be signed in to change notification settings - Fork 333
feat: add river-water and sea-water sourced heat pumps #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amos-schledorn
wants to merge
201
commits into
master
Choose a base branch
from
add-water-sourced-heat-pumps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
… calculations as outputs
…to add-water-sourced-heat-pumps
for more information, see https://pre-commit.ci
…to add-water-sourced-heat-pumps
for more information, see https://pre-commit.ci
…to add-water-sourced-heat-pumps
for more information, see https://pre-commit.ci
…asets to surpress warnings
…to add-water-sourced-heat-pumps
for more information, see https://pre-commit.ci
…ure dataset with source and licensing information
Co-authored-by: Fabian Neumann <[email protected]>
Co-authored-by: lkstrp <[email protected]>
…nclude 's_' prefix
…error handling in retrieval script
… on default cutout configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
Changes proposed in this Pull Request
This PR adds potential river-water and sea-water sourced heat pumps based on the implementations by @MajaHIC, @juboerms and @felix-land:
plotting:interactive_bus_balance:bus_name_pattern
), defaults toNone
Open TODOs
Checklist
envs/environment.yaml
.config/config.default.yaml
.doc/configtables/*.csv
.doc/data_sources.rst
.doc/release_notes.rst
is added.To be tracked in separate issues
Testing
Note: I've made these test runs with sea-water heat pump investment costs set to those of air-sourced heat pumps (fixed now but the results have not been re-computed).
Test config
Results
District heat balances
Sea-water heat pumps are built extensively, river-water heat pumps only sparingly. This is expected, due to unlimited sea-water use and river-water heat pump investment costs likely being overestimated.

Example of COP plot
Example of heat source plot
(river water temperature)
