-
Notifications
You must be signed in to change notification settings - Fork 705
v0.43 changelog: Bug fixes section #8401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add this entry? I will be merging this PR into rc now.
* Return `dtype` of `qml.samples` when using `mcm_method="tree-traversal"` is now `int` - consistent with other MCMs.
[(#8274)](https://github.com/PennyLaneAI/pennylane/pull/8274)
Could you please attach this:
to the entry about drawing and add the following bug fix entry:
Thanks! |
Hi @isaacdevlugt, just checking is OK that I add this change in this PR, since the entry is under the Resource-efficient decompositions section |
@gabrielasd thanks for checking this! I'll make this change in the base branch 👍. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.43-changelog #8401 +/- ##
==================================================
Coverage ? 99.42%
==================================================
Files ? 584
Lines ? 61234
Branches ? 0
==================================================
Hits ? 60883
Misses ? 351
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just some initial suggestions.
Co-authored-by: Andrija Paurevic <[email protected]>
Co-authored-by: Andrija Paurevic <[email protected]>
Co-authored-by: Andrija Paurevic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment. Could you also please add this entry to the bug fix section:
* Fixes a bug with `~.pennylane.estimator.resource_mapping._map_to_resource_op()` where it was incorrectly mapping the `~.TrotterProduct` template.
[(#8425)](https://github.com/PennyLaneAI/pennylane/pull/8425)
We will be merging the bug fix PR soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @andrijapau, |
No description provided.