Skip to content

Conversation

Jaybsoni
Copy link
Contributor

@Jaybsoni Jaybsoni commented Oct 7, 2025

Context:
TrotterProduct was not mapped correctly, additionally wires were not being passed between PL operators and their resource counterparts

Description of the Change:

@Jaybsoni Jaybsoni requested review from andrijapau and soranjh October 7, 2025 21:42
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@Jaybsoni Jaybsoni added this to the v0.43 milestone Oct 7, 2025
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v0.43.0-rc0@40eabf1). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             v0.43.0-rc0    #8425   +/-   ##
==============================================
  Coverage               ?   99.42%           
==============================================
  Files                  ?      584           
  Lines                  ?    61288           
  Branches               ?        0           
==============================================
  Hits                   ?    60936           
  Misses                 ?      352           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jaybsoni, left two questions.

@Jaybsoni Jaybsoni requested a review from soranjh October 8, 2025 21:32
@Jaybsoni Jaybsoni merged commit edc3f77 into v0.43.0-rc0 Oct 9, 2025
49 checks passed
@Jaybsoni Jaybsoni deleted the trotter_mapping_bug branch October 9, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants