-
Notifications
You must be signed in to change notification settings - Fork 705
Fix some bugs with the mapping function between PL operators and resource operators #8425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.43.0-rc0 #8425 +/- ##
==============================================
Coverage ? 99.42%
==============================================
Files ? 584
Lines ? 61288
Branches ? 0
==============================================
Hits ? 60936
Misses ? 352
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jaybsoni, left two questions.
Context:
TrotterProduct was not mapped correctly, additionally wires were not being passed between PL operators and their resource counterparts
Description of the Change: