[WIP&Messy] try to limit usage of IdSet with EntityRep #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not used anywhere and uses EntityRep together with IdSet.
blattms
force-pushed
the
feature/rename-id-with-EntityRep
branch
from
20cd1d8 to
b9ca0d7
Compare
blattms
added
the
manual:irrelevant
|
jenkins build this please |
This is not finished but might serve as inspiration.
blattms
force-pushed
the
feature/rename-id-with-EntityRep
branch
from
b9ca0d7 to
67be5c1
Compare
|
jenkins build this please |
|
jenkins build this serial please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should only be used internally if you know what you are doing.
Not finished and quite messy, but at least it compiles. Might serve as inspiration, though.
Main point is to rename the id method taklng an EntityRep to kind of prevent misusage. 😬
This might break the DUNE interface....