id(Entity) vs id(EntityRep): avoid derived-to-base conversion #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aritorto
added
the
manual:irrelevant
aritorto
force-pushed
the
idEntityOverload
branch
3 times, most recently
from
5028387 to
5f82bca
Compare
|
jenkins build this serial please |
aritorto
changed the title
aritorto
force-pushed
the
idEntityOverload
branch
from
457f7ab to
e1a4226
Compare
|
jenkins build this serial please |
1 similar comment
|
jenkins build this serial please |
aritorto
force-pushed
the
idEntityOverload
branch
from
ca53b0b to
ea615d7
Compare
|
jenkins build this serial please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids implicit derived-to-base conversion (use Entity instead of EntityRep) by overloading id with explicit types Entity, codim = 0 and 3, ensuring the correct ids are used for Entity<0> and Entity<3> in CpGrid with LGRs.
Alternative to #902, #905.
Cons: It ruins the efforts made in #892.
We expect the ids of
EntityandEntityRepto only coincide in the level zero grid, for CpGrid with LGRs.In serial execution, this works as intended.
However, tests show that in parallel execution, they also differ in level zero grid.
Bug-fix: synchronization of cell ids for the case when the grid has been refined via adapt() in both its distributed and global view, GlobalIdMapping.pointMapping_ was empty in this case.