-
-
Notifications
You must be signed in to change notification settings - Fork 143
Add PR Check Github Action Workflow #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JHWelch
wants to merge
5
commits into
MagicMirrorOrg:master
Choose a base branch
from
JHWelch:add-pr-check-workflow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+55
−7
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: Check Pull Request | ||
| on: | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - synchronize | ||
| - reopened | ||
| branches: | ||
| - master | ||
|
|
||
| concurrency: | ||
| group: pr-check-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout Repository | ||
| uses: actions/checkout@v5 | ||
|
|
||
| - name: Install Node.js | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: current | ||
|
|
||
| - name: Install Dependencies | ||
| run: npm ci --ignore-scripts | ||
|
|
||
| - name: Run Tests | ||
| run: npm run test | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,24 @@ | ||
| # Raspberry Specific | ||
|
|
||
| This information here is based on the latest release of | ||
| [Raspberry Pi OS](https://www.raspberrypi.com/software/operating-systems/) ("Trixie") from October 1st 2025. | ||
| This information here is based on the latest release of | ||
| [Raspberry Pi OS](https://www.raspberrypi.com/software/operating-systems/) | ||
| ("Trixie") from October 1st 2025. | ||
|
|
||
| ## Adding colored icons | ||
|
|
||
| Raspberry Pi OS does not come with colored emoji icons by default. To add them, install the following package: | ||
| Raspberry Pi OS does not come with colored emoji icons by default. To add them, | ||
| install the following package: | ||
|
|
||
| ```shell | ||
| sudo apt install fonts-noto-color-emoji | ||
| ``` | ||
|
|
||
| ## Rotating the screen | ||
|
|
||
| See the [official documentation](https://www.raspberrypi.com/documentation/computers/configuration.html#set-resolution-and-rotation) | ||
| See the | ||
| [official documentation](https://www.raspberrypi.com/documentation/computers/configuration.html#set-resolution-and-rotation) | ||
|
|
||
| In case you still run an older version of the Raspberry Pi OS, you can follow these instructions: | ||
| In case you still run an older version of the Raspberry Pi OS, you can follow | ||
| these instructions: | ||
|
|
||
| https://pimylifeup.com/raspberry-pi-rotate-screen/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ensures that if you push a new commit while tests are still running, it cancels the previous one, and only runs the new relevant one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I wonder if this could also be added to the main repo? What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a PR for the main repo (MagicMirrorOrg/MagicMirror#3943). I think with this, we can resolve this conversation and merge the PR, right? 🙂