Add PR Check Github Action Workflow #335
Open
+55
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JHWelch
commented
Oct 26, 2025
Comment on lines
+11
to
+13
| concurrency: | ||
| group: pr-check-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true |
Contributor
Author
There was a problem hiding this comment.
This ensures that if you push a new commit while tests are still running, it cancels the previous one, and only runs the new relevant one.
Collaborator
There was a problem hiding this comment.
Nice. I wonder if this could also be added to the main repo? What do you think?
Contributor
There was a problem hiding this comment.
I created a PR for the main repo (MagicMirrorOrg/MagicMirror#3943). I think with this, we can resolve this conversation and merge the PR, right? 🙂
KristjanESPERANTO
approved these changes
Oct 27, 2025
rejas
pushed a commit
to MagicMirrorOrg/MagicMirror
that referenced
this pull request
Nov 4, 2025
…uns (#3943) Add `concurrency` configuration to automatically cancel outdated test runs when new commits are pushed to the same PR/branch. Inspired by [MagicMirrorOrg/MagicMirror-Documentation#335](MagicMirrorOrg/MagicMirror-Documentation#335).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that right now both the Linting test and the Spelling test are both failing on
masterIf we add a GitHub workflow that checks on PRs, we can more easily notice these problems before they get merged. In fact, if a maintainer wants to add it to the
masterprotection Ruleset/branch protection you can require the workflow to pass.I added these both as a single job with:
npm run testThis does mean that if someone has both spelling AND linting problems, they will only see the linting first, and then the spelling.
I could split this into one workflow, two jobs, so they run in parallel and you get separate warnings, but I'm not sure if that is overkill, and this ensures if new things get added to
npm run testthey will automatically get run here.GItHub Actions are free for public repositories so this will not incur costs.
The second two commits here are resolving the problems.
You can see what failures look like on this Example PR in my fork JHWelch#1