Slightly rework how the wrapper handles arguments/parameters. #18
Conversation
|
I feel like a better solution would be to preserve original order of arguments and for any arguments added by wrapper (such as UUID extracted from username or accessToken from UUID) to be appended to the end of argument list. |
|
Alright, I've done up a better solution than before. This should preserve the order of arguments the user sets, and the wrapper appends its parameters at the end (if said parameters haven't been set by a launcher or user). I've also added Let me know if there's any changes you think should be made, or if there's probably another solution that would be better. |
JaiChoccyFox
changed the title
Instead of relying on 'parameters' & 'extraParameters' to determine what arguments to pass through to a client/server, use an array list that can store strings and parameter objects. This 'arguments' list is used to preserve the order of arguments that has been passed to the wrapper. An additional parameter also gets added: 'noParameters'. This prevents the wrapper from appending its parameters to the arguments list which is useful for servers.
This prevented the wrapper from appending parameters into arguments, however, the likely chance of someone needing to use this is close to 0. Unless someone really wanted to do this, it's pretty much unnecessary.
|
Alright, pushed a commit to remove |
Since LaunchWrapper is able to launch servers, it seems the current way it handles passing arguments to the main method doesn't account for old server versions which expect
noguias the first argument if the user wants to launch the server without GUI. This pull request adds a really small (and honestly silly) workaround for this case.There is likely a much better way of handling arguments passed through for servers but this'll work for now I guess.