Quick patch to address an accidental issue from PR #18 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrapper keeps track of a bunch of launch parameters for itself and those to be passed to a client/server, however, the recent update to how arguments are handled did not include the necessary for loop to append said parameters. This meant that arguments set by a launcher/user are parsed as normal, but the wrapper never appended its parameters to the end of the arguments list. This broke versions which expected parameters such as 'mppass' to always be present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #18 includes a commit (4cbdd83) to remove the
--noParametersswitch. I accidentally overlooked the fact that I had also removed theforloop which was necessary to append the rest of the wrapper's parameters to the end of the arguments list. This is a quick patch to address that by re-adding theforloop. All parameters were otherwise parsed just fine when set by a launcher/user.This fixes problems with versions that expected certain parameters to always be present. Example: connecting to a server on Classic versions would result in a NPE being thrown because
mppasswas not being passed to the client's arguments.