Skip to content

fix: fuse_main error handling #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fuse_main error handling #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion messages/bin_ltfs/root.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ root:table {
14120W:string { "Cannot access to directory %s, disabled index capture mode (%d)." }
14121I:string { "Index will be captured at %s at update" }
14122I:string { "Index will not be captured." }
14123W:string { "The main function of FUSE returned error (%d)." }
14123E:string { "The main function of FUSE returned (%d) errno (%d)." }

// 14150 - 14199 are reserved for LE+

Expand Down
3 changes: 2 additions & 1 deletion src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1336,7 +1336,8 @@ int single_drive_main(struct fuse_args *args, struct ltfs_fuse_data *priv)
ltfsmsg(LTFS_INFO, 14113I);
ret = fuse_main(args->argc, args->argv, &ltfs_ops, priv);
if (ret != 0) {
ltfsmsg(LTFS_WARN, 14123W, ret);
ltfsmsg(LTFS_ERR, 14123E, ret, errno);
return ret;
Copy link
Contributor

@amissael95 amissael95 Aug 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @madjesc, did you test that change? I created the message as a warning previously because the fuse_main return code was not checked before and I did not want to return inmediately since we were not able to replicate an issue when doing FUSE. Now that we have more experience a test can be defined to confirm that the return is safe to add.

}

/* Setup signal handler again to terminate cleanly */
Expand Down
Loading