fix: fuse_main error handling #543
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change the fuse main error handling
|
Thanks! |
amissael95
reviewed
Aug 29, 2025
| @@ -1336,7 +1336,8 @@ int single_drive_main(struct fuse_args *args, struct ltfs_fuse_data *priv) | |||
| ltfsmsg(LTFS_INFO, 14113I); | |||
| ret = fuse_main(args->argc, args->argv, <fs_ops, priv); | |||
| if (ret != 0) { | |||
| ltfsmsg(LTFS_WARN, 14123W, ret); | |||
| ltfsmsg(LTFS_ERR, 14123E, ret, errno); | |||
| return ret; | |||
There was a problem hiding this comment.
Hello @madjesc, did you test that change? I created the message as a warning previously because the fuse_main return code was not checked before and I did not want to return inmediately since we were not able to replicate an issue when doing FUSE. Now that we have more experience a test can be defined to confirm that the return is safe to add.
amissael95
requested changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the fuse main error handling
Description
Fix #541
Now the main function does not ignore the return code of fuse_main and uses the errno that fuse_main sets for better logging information
Type of change
Please delete items that are not relevant.
Checklist: