-
Notifications
You must be signed in to change notification settings - Fork 18
Bump min Python to 3.9 #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Python 3.8 is now end-of-life https://devguide.python.org/versions/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are now several unrelated changes mixed in a single PR. Would you mind to factor out everything which is not related to the cadquery bump?
The 3.8 -> 3.9 changes are related to the minimum supported version of CadQuery - when CadQuery went from 2.4 to 2.5 it dropped support for Python 3.8. But yes, I will otherwise focus the PR as much as I can to what is necessary for bumping CadQuery. I'll see if 2.4 works with recent Apple Silicon to avoid needing to bump the min Python, otherwise leave that in. |
Alright, but it would still be nice to do this in a separate PR, together with the Readme update, CI update and anything related to the Python update (and the .gitignore if you like). This is a no-brainer to merge. Then we can do the CadQuery update PR which needs more attention because CadQuery is an important dependency (and unfortunately the underlying OpenCascade library already caused lots of annoying problems, some of their official released versions are completely unusable for us - who knows if the new CadQuery version contains such a broken OpenCascade version). |
@z3ugma I approved the CI to run, but it looks like there's some problem with Python 3.12 :-/ Can you take care of that? |
Yep - looks to be a flake8 versioning problem -
|
I think that would be the best solution indeed - if you are motivated to do this change, I'd appreciate it. Alternatively one could consider dropping Python 3.12 & 3.13 for now to get the cadquery bump done, but it would just be a temporary workaround of course. The real problem needs to be fixed some day anyway. |
I can update the Ruff PR. |
I tried to match the existing isort config as close as possible.
Addresses part of #144 which involves CadQuery version support.
Python 3.8 is EOL
Newer versions of CadQuery don't support it so this PR drops support for Python 3.8