-
Notifications
You must be signed in to change notification settings - Fork 18
Use ruff for formatting #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no clear opinion about this. Generally I like consistent and enforced formatting and also the style looks quite good to me. But especially some configuration lists (e.g. FetConfig
or ChipConfig
) are getting more verbose / harder to read. Though not too bad I guess 🤔 Anyway, I would prefer a shorter line length.
Btw I never hear of ruff, so no opinions about that tool 😉
I'm a fan of autoformatters, as long as they allow sufficient control and can be disabled for certain parts of the code if necessary. So +1 from my side for ruff. |
7fe5e73
to
e4555bc
Compare
e1c1399
to
861e40e
Compare
861e40e
to
2d131f3
Compare
I tried to match the existing isort config as close as possible.
2d131f3
to
35b5125
Compare
Are you encouraging users to switch to for example:
as opposed to moving to this in pyproject.toml:
|
I'd suggest to do so, and adjust @rnestler Do you intend to add some |
@rnestler can you progress this Ruff formatting PR so that I can merge my changes that are behind it? Or let me know if you're busy and want to me take this over |
Sorry for radio silence 🙈 I was on holidays the last two weeks. |
@z3ugma If you have time and capacity you can take over, thanks for the offer 🙂 |
Due to the silence again, I have now applied all the |
This is just a quick PR to answer the following questions: