Skip to content

updating VectorizationBase to support julia 1.12 (continued) #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/Downstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
julia-version: [1,1.6]
julia-version: ['lts', '1', 'pre']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
julia-version: ['lts', '1', 'pre']
julia-version: ['min', 'lts', '1', 'pre']

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, min matches lts so that just adds more CI without being a real change.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't. They are different releases. min is 1.10.0 whereas lts is the latest 1.10 release (1.10.10 currently I think?).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min is different from lts (see https://github.com/JuliaSIMD/VectorizationBase.jl/pull/121/files#r2280324058):

Suggested change
julia-version: ['lts', '1', 'pre']
julia-version: ['min', 'lts', '1', 'pre']

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's take this conversation to a different PR, it at least shouldn't block the fix of pre.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I opened a separate PR: #123

os: [ubuntu-latest]
package:
- {user: JuliaSIMD, repo: LoopVectorization.jl, group: Interface}
Expand Down
46 changes: 0 additions & 46 deletions .github/workflows/ci-julia-nightly.yml

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: 'nightly'
version: 'pre'
- run: julia --color=yes -e 'using Pkg; VERSION >= v"1.5-" && !isdir(joinpath(DEPOT_PATH[1], "registries", "General")) && Pkg.Registry.add("General")'
shell: bash
env:
Expand All @@ -74,7 +74,7 @@ jobs:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: 'nightly'
version: 'pre'
- run: julia --color=yes -e 'using Pkg; VERSION >= v"1.5-" && !isdir(joinpath(DEPOT_PATH[1], "registries", "General")) && Pkg.Registry.add("General")'
shell: bash
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cix86.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: 'nightly'
version: 'pre'
- run: julia --color=yes -e 'using Pkg; VERSION >= v"1.5-" && !isdir(joinpath(DEPOT_PATH[1], "registries", "General")) && Pkg.Registry.add("General")'
shell: bash
env:
Expand All @@ -72,7 +72,7 @@ jobs:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: 'nightly'
version: 'pre'
- run: julia --color=yes -e 'using Pkg; VERSION >= v"1.5-" && !isdir(joinpath(DEPOT_PATH[1], "registries", "General")) && Pkg.Registry.add("General")'
shell: bash
env:
Expand Down
3 changes: 2 additions & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@ SIMDTypes = "0.1"
Static = "0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 1"
StaticArrayInterface = "1"
julia = "1.10"
Test = "<0.0.1, 1"

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Test"]
test = ["Test"]
1 change: 0 additions & 1 deletion docs/make.jl
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ makedocs(;
canonical = "https://JuliaSIMD.github.io/VectorizationBase.jl"
),
pages = ["Home" => "index.md"],
strict = false
)

deploydocs(; repo = "github.com/JuliaSIMD/VectorizationBase.jl")
16 changes: 15 additions & 1 deletion src/VectorizationBase.jl
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,20 @@ using HostCPUFeatures:
nextpow2,
fast_half

import Base:
Float16,
Float32,
Float64,
Int8,
Int16,
Int32,
Int64,
UInt8,
UInt16,
UInt32,
UInt64,
Bool

using SIMDTypes:
Bit,
FloatingTypes,
Expand Down Expand Up @@ -167,7 +181,7 @@ julia> rgbs = [
B = Float32(i + 200) / 255
) for i = 0:7:49
]
8-element Vector{NamedTuple{(:R, :G, :B), Tuple{Float32, Float32, Float32}}}:
8-element Vector{@NamedTuple{R::Float32, G::Float32, B::Float32}}:
(R = 0.0, G = 0.39215687, B = 0.78431374)
(R = 0.02745098, G = 0.41960785, B = 0.8117647)
(R = 0.05490196, G = 0.44705883, B = 0.8392157)
Expand Down
1 change: 0 additions & 1 deletion src/llvm_intrin/binary_ops.jl
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

function binary_op(op, W, @nospecialize(T))
ty = LLVM_TYPES[T]
if isone(W)
Expand Down
1 change: 0 additions & 1 deletion src/llvm_intrin/conflict.jl
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

function conflictquote(W::Int = 16, bits::Int = 32)
@assert bits == 32 || bits == 64
s = bits == 32 ? 'd' : 'q'
Expand Down
1 change: 0 additions & 1 deletion src/llvm_intrin/integer_fma.jl
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

# This is experimental, as few arches support it, and I can't think of many uses other than floating point RNGs.

@inline __ifmalo(v1, v2, v3) =
Expand Down
1 change: 0 additions & 1 deletion src/llvm_intrin/intrin_funcs.jl
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

@generated function saturated(::F, x::I, y::I) where {I<:IntegerTypesHW,F}
typ = "i$(8sizeof(I))"
s = I <: Signed ? 's' : 'u'
Expand Down
1 change: 0 additions & 1 deletion src/llvm_intrin/masks.jl
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#
# We use these definitions because when we have other SIMD operations with masks
# LLVM optimizes the masks better.
function truncate_mask!(instrs, input, W, suffix, reverse_load::Bool = false)
Expand Down
Loading
Loading