-
Notifications
You must be signed in to change notification settings - Fork 32
updating VectorizationBase to support julia 1.12 (continued) #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e8b0e74
0ef4d39
3ff76ea
c2e98ff
2804ed3
68f31d7
794d07a
676b668
814d181
a74ebae
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -14,7 +14,7 @@ jobs: | |||||
strategy: | ||||||
fail-fast: false | ||||||
matrix: | ||||||
julia-version: [1,1.6] | ||||||
julia-version: ['lts', '1', 'pre'] | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's take this conversation to a different PR, it at least shouldn't block the fix of pre. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point, I opened a separate PR: #123 |
||||||
os: [ubuntu-latest] | ||||||
package: | ||||||
- {user: JuliaSIMD, repo: LoopVectorization.jl, group: Interface} | ||||||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
|
||
function binary_op(op, W, @nospecialize(T)) | ||
ty = LLVM_TYPES[T] | ||
if isone(W) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
|
||
function conflictquote(W::Int = 16, bits::Int = 32) | ||
@assert bits == 32 || bits == 64 | ||
s = bits == 32 ? 'd' : 'q' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, min matches lts so that just adds more CI without being a real change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it doesn't. They are different releases.
min
is 1.10.0 whereaslts
is the latest 1.10 release (1.10.10 currently I think?).