-
Notifications
You must be signed in to change notification settings - Fork 32
updating VectorizationBase to support julia 1.12 (continued) #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -14,7 +14,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
julia-version: [1,1.6] | |||
julia-version: ['lts', '1', 'pre'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
julia-version: ['lts', '1', 'pre'] | |
julia-version: ['min', 'lts', '1', 'pre'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, min matches lts so that just adds more CI without being a real change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it doesn't. They are different releases. min
is 1.10.0 whereas lts
is the latest 1.10 release (1.10.10 currently I think?).
@oscardssmith the spurious doc failures were because that was building with nightly. |
@@ -14,7 +14,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
julia-version: [1,1.6] | |||
julia-version: ['lts', '1', 'pre'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min
is different from lts
(see https://github.com/JuliaSIMD/VectorizationBase.jl/pull/121/files#r2280324058):
julia-version: ['lts', '1', 'pre'] | |
julia-version: ['min', 'lts', '1', 'pre'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's take this conversation to a different PR, it at least shouldn't block the fix of pre.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I opened a separate PR: #123
Codecov Report❌ Patch coverage is
Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@oscardssmith are those integration tests all the same failures as master? |
yes. I think this is ready to merge. |
Rebased and cleaned up commit history of #119
Part of my submission for the Updating LoopVectorization Project from the SciML small grants program.