Skip to content

updating VectorizationBase to support julia 1.12 (continued) #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 18, 2025

Conversation

mxpoch
Copy link
Contributor

@mxpoch mxpoch commented Aug 7, 2025

Rebased and cleaned up commit history of #119

Part of my submission for the Updating LoopVectorization Project from the SciML small grants program.

@mxpoch
Copy link
Contributor Author

mxpoch commented Aug 12, 2025

@oscardssmith

@@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
julia-version: [1,1.6]
julia-version: ['lts', '1', 'pre']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
julia-version: ['lts', '1', 'pre']
julia-version: ['min', 'lts', '1', 'pre']

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, min matches lts so that just adds more CI without being a real change.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't. They are different releases. min is 1.10.0 whereas lts is the latest 1.10 release (1.10.10 currently I think?).

@ChrisRackauckas
Copy link
Member

@oscardssmith the spurious doc failures were because that was building with nightly.

@@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
julia-version: [1,1.6]
julia-version: ['lts', '1', 'pre']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min is different from lts (see https://github.com/JuliaSIMD/VectorizationBase.jl/pull/121/files#r2280324058):

Suggested change
julia-version: ['lts', '1', 'pre']
julia-version: ['min', 'lts', '1', 'pre']

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's take this conversation to a different PR, it at least shouldn't block the fix of pre.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I opened a separate PR: #123

Copy link

codecov bot commented Aug 16, 2025

Codecov Report

❌ Patch coverage is 44.53125% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.25%. Comparing base (a97af99) to head (a74ebae).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
src/llvm_intrin/memory_addr.jl 44.73% 63 Missing ⚠️
src/strided_pointers/stridedpointers.jl 0.00% 4 Missing ⚠️
src/llvm_types.jl 40.00% 3 Missing ⚠️
src/llvm_intrin/vbroadcast.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #121       +/-   ##
===========================================
+ Coverage   23.19%   52.25%   +29.06%     
===========================================
  Files          35       35               
  Lines        5838     6145      +307     
===========================================
+ Hits         1354     3211     +1857     
+ Misses       4484     2934     -1550     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oscardssmith oscardssmith enabled auto-merge August 18, 2025 15:13
@oscardssmith oscardssmith disabled auto-merge August 18, 2025 15:13
@ChrisRackauckas
Copy link
Member

@oscardssmith are those integration tests all the same failures as master?

@oscardssmith
Copy link
Member

yes. I think this is ready to merge.

@ChrisRackauckas ChrisRackauckas merged commit 129a0e5 into JuliaSIMD:master Aug 18, 2025
22 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants