-
Notifications
You must be signed in to change notification settings - Fork 63
fix AD demos on Julia nightly #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are we not testing on nightly currently? |
I thnk we're supposed to be (https://github.com/JuliaDiff/ChainRulesCore.jl/blob/decfca42702ff11a6c4b97c3563498e19415407a/.github/workflows/JuliaNightly.yml) But doesn't look like it's actually running. Maybe @oxinabox knows what the situation is? |
Ah, so it's not run on every PR, but instead just once per day on master. I think it would make sense to at least test nightly on one platform on every PR, so problems are noticed right away. |
opened #300 :) |
How does CD here work nowadays? Should I bump the version as well and then register afterwards? Or do we now have a tool for that? |
Yes, do that |
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
==========================================
- Coverage 89.61% 87.85% -1.76%
==========================================
Files 13 13
Lines 462 420 -42
==========================================
- Hits 414 369 -45
- Misses 48 51 +3
Continue to review full report at Codecov.
|
This was broken by JuliaLang/julia#38136