Skip to content

Should we run CI with Julia Nightly Version on PRs? #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nickrobinson251 opened this issue Feb 8, 2021 · 0 comments · Fixed by #301
Closed

Should we run CI with Julia Nightly Version on PRs? #300

nickrobinson251 opened this issue Feb 8, 2021 · 0 comments · Fixed by #301
Labels
testing

Comments

@nickrobinson251
Copy link
Contributor

moved from #299 (comment)

We run CI on Julia Nightly version, but only as a cron job (https://github.com/JuliaDiff/ChainRulesCore.jl/blob/decfca42702ff11a6c4b97c3563498e19415407a/.github/workflows/JuliaNightly.yml)

I don't know what benefit there is to the cron job, as i'm not sure who looks at it (and we don't want notifications, since Julia Nightly is broken somewhat regularly). So i think if we want to catch Julia Nightly failures, we might be better off having CI run on Julia Nightly on each pull request (and as usual just not considering failures on Julia Nightly to be blocking issues)
@nickrobinson251 nickrobinson251 mentioned this issue Feb 8, 2021
Merged
@nickrobinson251 nickrobinson251 changed the title Shoudl we run CI with Julia Nightly Version on PRs? Should we run CI with Julia Nightly Version on PRs? Feb 8, 2021
@simeonschaub simeonschaub mentioned this issue Feb 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test Julia nightly on every PR JuliaDiff/ChainRulesCore.jl
1 participant
@nickrobinson251