Skip to content

Conversation

ejgoldik
Copy link

Update MIPI RGB metadata to 0x80010001.
This has to be merged along with the FW counterpart

@ejgoldik ejgoldik requested a review from Copilot October 16, 2025 10:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a MIPI RGB metadata type mismatch issue (DSO-18159) for the D457 device by reverting from a workaround value to the correct metadata ID. The change removes the temporary workaround that mapped MIPI RGB frames to the same ID as standard RGB control frames and restores the proper distinct metadata type for MIPI RGB frames.

  • Removes the workaround META_DATA_MIPI_INTEL_RGB_ID entry that used ID 0x80000005
  • Restores the correct META_DATA_MIPI_INTEL_RGB_ID with ID 0x80010001

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ejgoldik ejgoldik requested review from Nir-Az and ymodlin October 16, 2025 10:22
@Nir-Az
Copy link
Collaborator

Nir-Az commented Oct 16, 2025

Since this a breaking change we have 2 options to address it:

  • Set ID according to FW version
  • Increase the min FW version for MIPI devices

Let's device together, please do not merge it to FW until we align with an SDK solution
If needed we can open SDK team a ticket to handle it with this PR as reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants