Skip to content

Conversation

@aperezdc
Copy link
Member

This PR incorporates the changes from #66, and the minimal amount of changes from #57 needed to update to WPE WebKit 2.48.x, and therefore supersedes both of them. Likely makes some changes from #58 unneeded as well.

The WPE WebKit recipe itself gets a few changes:

  • Pass -DENABLE_SPEECH_SYNTHESIS=OFF, given that we do not have either the FLite or Spiel package needed by this feature.
  • Adapt to the inspector resources now being shipped as a .gresource data file.
  • Remove setting LDFLAGS, CFLAGS, and CXXFLAGS tweaks which are no longer needed.
  • Drop existing patches, given they are included in 2.48.2 as backports.
  • Add the patch from wpewebkit: Temporary fix for fdsan abort #66 that workarounds the fdsan runtime crash.

As for the WebKit dependencies that needed updating:

  • Harfbuzz gets updated to 10.4.0, libxml to 2.14.2, by cherry picking the changes from upstream Cerbero. Doing it this way instead of a single commit will make it more tractable when we merge more changes from upstream.
  • libxslt gets updated to 1.1.42, and the sources switched to official tarballs instead of the ones automatically generated by GitLab. This puts less stress on the GNOME infrastructure, the fetched package is smaller and the configuration step takes less time because the autoreconf invocation is no longer needed.
  • ICU gets updated to 70.1, the minimum required version by 2.48.x. This version also no longer needs the autoreconf invocation, making the configuration step faster.

ylatuya and others added 12 commits May 26, 2025 14:47
This ensure it depends on gobject-introspection and it's
built with introspection

Part-of: <https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1587>
introspection files were expected, but introspection wasn't enabled.
introspection also needs gobject support, and the subset library is
not used by gstreamer.

Part-of: <https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1609>
@aperezdc aperezdc requested review from neodesys and spenap May 26, 2025 12:00
@aperezdc aperezdc self-assigned this May 26, 2025
@aperezdc aperezdc changed the title Aperezdc/wpewebkit 2.48 minimal Update WPE WebKit to 2.48.2 May 26, 2025
@aperezdc aperezdc force-pushed the aperezdc/wpewebkit-2.48-minimal branch from e92465a to be99a2e Compare May 26, 2025 12:03
aperezdc added 3 commits May 26, 2025 18:14
Only gst-plugins-bad requires librsvg, but the corresponding element
is not needed by WebKit (it has its own internal SVG support), hence
it may be disabled.
ICU version 70.1 is required by WPE WebKit 2.48.x
The following changes were needed:

- Pass -DENABLE_SPEECH_SYNTHESIS=OFF, given that we do not have either
  the FLite or Spiel package needed by this feature.
- Adapt to the inspector resources now being shipped as a .gresource
  data file.
- Remove setting LDFLAGS, CFLAGS, and CXXFLAGS tweaks which are no
  longer needed.
- Drop existing patches, given they are included in 2.48.2 as backports.
- Add a patch with a revert to workaround a fdsan runtime crash.
@aperezdc aperezdc force-pushed the aperezdc/wpewebkit-2.48-minimal branch from be99a2e to dadf545 Compare May 26, 2025 15:14
@aperezdc aperezdc merged commit fd57c57 into main May 26, 2025
5 of 6 checks passed
@aperezdc aperezdc deleted the aperezdc/wpewebkit-2.48-minimal branch May 26, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants