forked from GStreamer/cerbero
-
Notifications
You must be signed in to change notification settings - Fork 10
Update WPE WebKit to 2.48.2 #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensure it depends on gobject-introspection and it's built with introspection Part-of: <https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1587>
introspection files were expected, but introspection wasn't enabled. introspection also needs gobject support, and the subset library is not used by gstreamer. Part-of: <https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1609>
The macOS/iOS build error is now addressed upstream, see harfbuzz/harfbuzz@60c6b77 Fixes #516 Part-of: <https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1756>
…ream version Co-authored-by: L. E. Segovia <[email protected]> Part-of: <https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1496>
e92465a to
be99a2e
Compare
neodesys
approved these changes
May 26, 2025
Only gst-plugins-bad requires librsvg, but the corresponding element is not needed by WebKit (it has its own internal SVG support), hence it may be disabled.
ICU version 70.1 is required by WPE WebKit 2.48.x
The following changes were needed: - Pass -DENABLE_SPEECH_SYNTHESIS=OFF, given that we do not have either the FLite or Spiel package needed by this feature. - Adapt to the inspector resources now being shipped as a .gresource data file. - Remove setting LDFLAGS, CFLAGS, and CXXFLAGS tweaks which are no longer needed. - Drop existing patches, given they are included in 2.48.2 as backports. - Add a patch with a revert to workaround a fdsan runtime crash.
be99a2e to
dadf545
Compare
This was referenced May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates the changes from #66, and the minimal amount of changes from #57 needed to update to WPE WebKit 2.48.x, and therefore supersedes both of them. Likely makes some changes from #58 unneeded as well.
The WPE WebKit recipe itself gets a few changes:
-DENABLE_SPEECH_SYNTHESIS=OFF, given that we do not have either the FLite or Spiel package needed by this feature..gresourcedata file.LDFLAGS,CFLAGS, andCXXFLAGStweaks which are no longer needed.fdsanruntime crash.As for the WebKit dependencies that needed updating:
autoreconfinvocation is no longer needed.autoreconfinvocation, making the configuration step faster.