Support building WPE WebKit ToT #58
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The builders failing to build... is likely a consequence of |
|
Upstream PR for |
|
And for |
spenap
force-pushed
the
spena/wpe-android-tot
branch
2 times, most recently
from
9e06cef to
74f78c4
Compare
After upstreaming some of the remaining patches, only a revert is needed to build.
spenap
force-pushed
the
spena/wpe-android-tot
branch
from
74f78c4 to
5bb163f
Compare
|
When trying this, I have the following problem: |
|
@aperezdc , I have the same fdsan error, I believe, in this simpler PR. If I had to guess, I'd say it's something we're inheriting in the delta between 2.46 (working) and 2.48, and main simply has it as it incorporates 2.48 |
|
This will likely need a rework after #67 gets landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an unverified PR that does the bare minimum to compile WPE WebKit ToT, bumping icu and libxml to their minimum versions, and updating the WPE WebKit recipe with the latest versions of patches.
This is missing a patch to use
gresourcefor the injected bundle -- something that @aperezdc 's more ambitious #57 does, and as I haven't yet run minibrowser on Android, it might be hiding other problems.I had to make a minor modification to the upstreamed patch to build WebDriver as an executable or as a library -- as otherwise it complains about the WebKit namespace. From @aperezdc 's comments, I understand https://github.com/Igalia/wpe-android/blob/b918e3f8b86eda406436cb251c2e7b10a529008c/wpeview/src/main/cpp/Service/EntryPoint.cpp#L55 would need changing anyway, as it is still expecting the old entry point -- which this PR uses.
I had to revert https://commits.webkit.org/293591@main as it changes the way includes are added to generated messages, and that doesn't seem to work in our Cerbero build -- could be a problem with the compiler version we're using, not sure.
There are two minor build fix patches that I'll attempt to upstream now.