Skip to content

UpdateHandler: Check against releases not commits #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

UpdateHandler: Check against releases not commits #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions YUViewLib/src/handler/UpdateHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,11 @@ void updateHandler::startCheckForNewVersion(bool userRequest, bool force)
}
else if (VERSION_CHECK)
{
// We can check the Github API for the commit hash. After that we can say if there is a new version available on Github.
// We can check the Github API for the release. After that we can say if there is a new version available on Github.
updaterStatus = updaterChecking;
userCheckRequest = userRequest;
DEBUG_UPDATE("updateHandler::startCheckForNewVersion get https://api.github.com/repos/IENT/YUView/commits");
networkManager.get(QNetworkRequest(QUrl("https://api.github.com/repos/IENT/YUView/commits")));
DEBUG_UPDATE("updateHandler::startCheckForNewVersion get https://api.github.com/repos/IENT/YUView/releases");
networkManager.get(QNetworkRequest(QUrl("https://api.github.com/repos/IENT/YUView/releases")));
}
else
{
Expand Down Expand Up @@ -278,16 +278,16 @@ void updateHandler::replyFinished(QNetworkReply *reply)
else
{
QJsonObject jsonObject = jsonArray[0].toObject();
if (!jsonObject.contains("sha"))
if (!jsonObject.contains("tag_name"))
{
error = true;
errorString = "The returned JSON object does not contain sha information on the latest commit hash.";
errorString = "The returned JSON object does not contain version information on the latest release.";
}
else
{
QString serverHash = jsonObject["sha"].toString();
QString buildHash = QString::fromUtf8(YUVIEW_HASH);
if (serverHash != buildHash)
QString serverVersion = jsonObject["tag_name"].toString();
QString buildVersion = QString::fromUtf8(YUVIEW_VERSION);
if (serverVersion != buildVersion)
{
QMessageBox msgBox;
msgBox.setTextFormat(Qt::RichText);
Expand Down