UpdateHandler: Check against releases not commits #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this for the flathub release where an "new version" dialog was shown on every launch.
The dialog contains a link to https://github.com/IENT/YUView/releases which of course doesn't have a newer version.
Perhaps this branch needs more thought and should check the releases endpoint when compiled from a tagged branch and commits when compiled from
developassuming that would be useful.Initially this patch was in an MR for the flathub (flathub/de.rwth_aachen.ient.YUView#21) which I've updated to simply remove the network permission. I couldn't see any other features that this software uses network access for and directing the user to update in that context isn't useful, unless the flathub repo becomes unmaintained.